diff --git a/src/util/geo/Geo.h b/src/util/geo/Geo.h index dc52d4a..570ba66 100644 --- a/src/util/geo/Geo.h +++ b/src/util/geo/Geo.h @@ -398,9 +398,9 @@ inline bool intersects(const LineSegment& ls1, const LineSegment& ls2) { return intersects(getBoundingBox(ls1), getBoundingBox(ls2)) && (contains(ls1.first, ls2) || contains(ls1.second, ls2) || contains(ls2.first, ls1) || contains(ls2.second, ls1) || - ((crossProd(ls1.first, ls2) < 0) ^ - (crossProd(ls1.second, ls2) < 0)) || - ((crossProd(ls2.first, ls1) < 0) ^ (crossProd(ls2.second, ls1) < 0))); + (((crossProd(ls1.first, ls2) < 0) ^ + (crossProd(ls1.second, ls2) < 0)) && + ((crossProd(ls2.first, ls1) < 0) ^ (crossProd(ls2.second, ls1) < 0)))); } // _____________________________________________________________________________ @@ -953,7 +953,7 @@ inline Point projectOn(const Point& a, const Point& b, if (doubleEq(a.getX(), c.getX()) && doubleEq(a.getY(), c.getY())) return a; if (doubleEq(b.getX(), c.getX()) && doubleEq(b.getY(), c.getY())) return b; - double x, y; + T x, y; if (c.getX() == a.getX()) { // infinite slope @@ -963,8 +963,8 @@ inline Point projectOn(const Point& a, const Point& b, double m = (double)(c.getY() - a.getY()) / (c.getX() - a.getX()); double bb = (double)a.getY() - (m * a.getX()); - x = (m * b.getY() + b.getX() - m * bb) / (m * m + 1); - y = (m * m * b.getY() + m * b.getX() + bb) / (m * m + 1); + x = (m * b.getY() + b.getX() - m * bb) / (m * m + 1.0); + y = (m * m * b.getY() + m * b.getX() + bb) / (m * m + 1.0); } Point ret = Point(x, y); @@ -1017,7 +1017,7 @@ inline double parallelity(const Box& box, const MultiLine& multiline) { ret += parallelity(box, l); } - return ret / multiline.size(); + return ret / static_cast(multiline.size()); } // _____________________________________________________________________________ diff --git a/src/util/tests/TestMain.cpp b/src/util/tests/TestMain.cpp index dbf1eb5..4e5ec62 100644 --- a/src/util/tests/TestMain.cpp +++ b/src/util/tests/TestMain.cpp @@ -976,6 +976,8 @@ CASE("geometry") { EXPECT(geo::intersects(lsb, lsb)); EXPECT(!geo::intersects(lsa, lsc)); + EXPECT(!geo::intersects(geo::Point(871569.2, 6104550.4), geo::Point(871581.2, 6104536), geo::Point(871580.3, 6104541.3), geo::Point(871625.7, 6104510.1))); + geo::Line l{geo::Point(1, 1), geo::Point(2, 2), geo::Point(2, 4)}; EXPECT(!geo::contains(geo::Point(1, 2), l)); EXPECT(geo::contains(geo::Point(2, 2), l));