gtfs-actions/generate-shapes
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove TODOs

Browse source
This commit is contained in:
Patrick Brosi 2024-02-15 12:43:25 +01:00
parent eda6f50fbb
commit 67b9f7f6d2
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/pfaedle/router/ShapeBuilder.cpp
View file

@ -346,7 +346,6 @@ std::map<size_t, EdgeListHops> ShapeBuilder::shapeify(
const TripTrie<pfaedle::gtfs::Trip>* trie, HopCache* hopCache) const { const TripTrie<pfaedle::gtfs::Trip>* trie, HopCache* hopCache) const {
LOG(VDEBUG) << "Map-matching trie " << trie; LOG(VDEBUG) << "Map-matching trie " << trie;
// TODO(patrick): assumes the trie is not empty, check this!
assert(trie->getNdTrips().size()); assert(trie->getNdTrips().size());
assert(trie->getNdTrips().begin()->second.size()); assert(trie->getNdTrips().begin()->second.size());
RoutingAttrs rAttrs = getRAttrs(trie->getNdTrips().begin()->second[0]); RoutingAttrs rAttrs = getRAttrs(trie->getNdTrips().begin()->second[0]);
@ -838,9 +837,8 @@ double ShapeBuilder::timePen(int candTime, int schedTime) const {
// _____________________________________________________________________________ // _____________________________________________________________________________
EdgeCandGroup ShapeBuilder::timeExpand(const EdgeCand& ec, int time) const { EdgeCandGroup ShapeBuilder::timeExpand(const EdgeCand& ec, int time) const {
EdgeCandGroup ret; EdgeCandGroup ret;
// TODO(patrick): heuristic for time expansion variance // TODO(patrick): heuristic for time expansion variance, currently
// for (int i = -5; i < 6; i++) { // unused
// for (int i = -10; i < 1; i++) {
for (int i = 0; i < 1; i++) { for (int i = 0; i < 1; i++) {
EdgeCand ecNew = ec; EdgeCand ecNew = ec;
// in 30 sec steps // in 30 sec steps

1
src/pfaedle/router/TripTrie.tpp
View file

@ -193,7 +193,6 @@ size_t TripTrie<TRIP>::getMatchChild(size_t parentNid,
const std::string& platform, POINT pos, const std::string& platform, POINT pos,
int time, bool timeEx) const { int time, bool timeEx) const {
for (size_t child : _nds[parentNid].childs) { for (size_t child : _nds[parentNid].childs) {
// TODO(patrick): use similarity classification here?
if (_nds[child].stopName == stopName && _nds[child].platform == platform && if (_nds[child].stopName == stopName && _nds[child].platform == platform &&
util::geo::dist(_nds[child].pos, pos) < 1 && util::geo::dist(_nds[child].pos, pos) < 1 &&
(!timeEx || _nds[child].time == time)) { (!timeEx || _nds[child].time == time)) {